Notoriety Error Fix

Hello everyone

I'm here to present you my Notoriety Error Fix.

What does it do:
After studying and editing this file for a very long time I found a couple of errors which Volition forgot to patch. This mod will fix those bugs.

Exact changes:
- Fixed a script error which placed an SNG soldier as the pilot of the SWAT Tornado. It now is a SWAT officer, just like it is supposed to be.

- Fixes a script error which puts 3 police officers in each police car when reaching notoriety level 4. There are now 2 cops per car, just like it was supposed to be.

- Fixed another script error which caused 3 officers to be in a police car when reaching notoriety level 3 when STAG is active. There are now 2 police officers per car, just like it should be.

- Activated a new roadblock spawn which was included in the files (a second variant for the level 3 police blockades on the 2 lane roads) but which couldn't spawn because it wasn't included in the file which set the type of roadblocks that could be spawned.

- Fixed an script error which prevented the SWAT Lockdown to appear at notoriety level 3. In the vanilla game, at notoriety level 3 there will be black police cars spawning every now and then. But according to the notoriety spawn file there is a 70% chance that these would spawn but also a 30% that a SWAT Lockdown should spawn. But due to an script error the SWAT Lockdown couldn't spawn and now only the black cop cars spawn.

How to install:
Simply download the fix and extract all files to you Saints Row The Third installation folder.


For those who understand the above can download the fix and install it.

For those who are wondering how these errors where caused, below here you can see a full description I wrote.


The Bug (1)

The bug which caused an SNG soldier to pilot the SWAT Tornado. (Can clearly be spotted after putting the Tornado on the ground with the RC pocessor so that the pilot gets out.)

This bug was caused because of an error in with the tags.

This is the original code:

Code:
        <group_info>
            <group_info>
                <level>4</level>
                <chance>1</chance>
                <tag_name>G_GuardAtHelo</tag_name>
                <vehicle_name>heli_fighter_01</vehicle_name>
                <variant_name>police</variant_name>
                </group_info>
            <group_info>
                <level>5</level>
                <chance>1</chance>
                <tag_name>G_GuardAtHelo</tag_name>
                <vehicle_name>heli_fighter_02</vehicle_name>
                <variant_name>ng</variant_name>
                </group_info>
            </group_info>
        <group_details>
            <group_details>
                <tag_name>G_GuardAtHelo</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                </group_details>
            </group_details>

So basically this part of the code sets the type of vehicle that spawns, the chance of the vehicle spawning (100% chance since there is no second vehicle) and the driver and its passengers.

The first group info sets the vehicle for level 4. 'Heli_fighter_01' is the internal name for the Tornado attack chopper and the police variant means that it is the SWAT variant of the tornado. The second group info sets the vehicle for level 5. Just like above it sets the same values but instead the Vulture helicopter and the NG variant of it.

Below that you can find the tab 'group details'. There you can see the tag name which is 'G_GuardAtHelo'. You can see next to npc_name it states 'npc_ng_male_soldier', this it the national guard soldier.

Well this it the bug: In the group info section you can see that both SWAT helicopter and SNG helicopter have the same tag name. The author of this file entered SNG soldier as pilot because it off the SNG Vulture which appears at shields, forgetting about the SWAT tornado. And since both choppers have the same tag name, the SWAT Tornado also spawns with a soldier as pilot.

The Fix

I left the SNG helicopter its tag name with the soldier be, so the Vulture which shows up at 5 shields still has the SNG soldier piloting it.

To fix this bug, I created a new tag, for the SWAT Tornado and in that tag I set the pilot to be the SWAT officer. Simple, right?

Fixed code:

Code:
        <group_info>
            <group_info>
                <level>4</level>
                <chance>1</chance>
                <tag_name>G_SWATAtHelo</tag_name>
                <vehicle_name>heli_fighter_01</vehicle_name>
                <variant_name>police</variant_name>
                </group_info>
            <group_info>
                <level>5</level>
                <chance>1</chance>
                <tag_name>G_GuardAtHelo</tag_name>
                <vehicle_name>heli_fighter_02</vehicle_name>
                <variant_name>ng</variant_name>
                </group_info>
            </group_info>
        <group_details>
            <group_details>
                <tag_name>G_SWATAtHelo</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop_SWAT01_mw</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                </group_details>
            <group_details>
                <tag_name>G_GuardAtHelo</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                </group_details>
            </group_details>

The Bug (2)

The bug which caused the police car at notoriety 4 to contain 3 police officers instead of two.

This bug was also caused by a problem with the tags.

This is the original code:

Code:
    <Table>
        <Name>police</Name>
        <level_info>
            <level_info>
                <level>4</level>
                <min_spawn_time>15</min_spawn_time>
                <max_spawn_time>20</max_spawn_time>
                <max_vehicle_occupants>3</max_vehicle_occupants>
                <max_vehicles>3</max_vehicles>
                <npc_cap>8</npc_cap>
                <specialist_cap>1</specialist_cap>
                <brute_cap>0</brute_cap>
                <veh_min_spawn_time>5</veh_min_spawn_time>
                <veh_max_spawn_time>10</veh_max_spawn_time>
                </level_info>
            </level_info>
        <_Editor>
            <Category>Entries:Police/NG</Category>
            </_Editor>
        <spawn_flags>
            <Flag>Spawn on Land</Flag>
            </spawn_flags>
        <override_group>police_motorcycle</override_group>
        <group_info>
            <group_info>
                <level>4</level>
                <chance>0.60</chance>
                <tag_name>G_CopCar</tag_name>
                <vehicle_name>car_4dr_police02</vehicle_name>
                <variant_name>average</variant_name>
                </group_info>
            <group_info>
                <level>4</level>
                <chance>0.20</chance>
                <tag_name>G_Guard_Humvee</tag_name>
                <vehicle_name>suv_4dr_luxury05T</vehicle_name>
                <variant_name>Military</variant_name>
                </group_info>
            <group_info>
                <level>4</level>
                <chance>0.20</chance>
                <tag_name>G_Guard_Humvee2</tag_name>
                <vehicle_name>suv_4dr_luxury05T</vehicle_name>
                <variant_name>Military</variant_name>
                </group_info>
            </group_info>
        <group_details>
            <group_details>
                <tag_name>G_CopCar</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee</tag_name>
                <seat_name>Passenger 4</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee</tag_name>
                <seat_name>Passenger 2</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee2</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee2</tag_name>
                <seat_name>Passenger 4</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee2</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_Guard_Humvee2</tag_name>
                <seat_name>Passenger 2</seat_name>
                <npc_name>npc_ng_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            </group_details>
        </Table>

Before we continue I want to make one important note: I've cutted out certain parts of the code like the spawn codes for other levels then notoriety 4, to shorten the lenght off this page. Only essential parts have been spared.

How is the bug caused?

According to the files, there is a 60% chance rate a police car spawns at level 4 and 40% chance an SNG bulldog spawns. What you should know: A police car has 2 occupants (driver and passenger) and an SNG bulldog has 3 (driver, passenger and gunner)

The error the author of the file created was basically this: At the top of the code you can see this:


<level>4</level>
<min_spawn_time>15</min_spawn_time>
<max_spawn_time>20</max_spawn_time>
<max_vehicle_occupants>3</max_vehicle_occupants>
<max_vehicles>3</max_vehicles>
<npc_cap>8</npc_cap>
<specialist_cap>1</specialist_cap>
<brute_cap>0</brute_cap>
<veh_min_spawn_time>5</veh_min_spawn_time>
<veh_max_spawn_time>10</veh_max_spawn_time>




In bold you can see that the author set the max vehicle occupants to 3, because an SNG bulldog contains three occupants. But he forgot about the police car and because both police car and SNG bulldog use the same spawn tab, police car has 3 occupants instead of two.

The Fix

Very easy, just make a change to the police car its tag that it can only have a driver and passenger.

This is the original bugged code:

Code:
            <group_details>
                <tag_name>G_CopCar</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>

You can see that seat_name has been set as Default and npc_name to npc_cop. Basically what now happens is that this part says that every occupant of the police car is a police officer. But the amount of occupants is being handled by the in bold put codeline you saw earlier.

This is the fixed code:
Code:
            <group_details>
                <tag_name>G_CopCar</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_CopCar</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>

What you can see now is that I changed Default to Driver and pasted and copied the whole bit of code and changed seat_name to Passenger 1 (which is the seat next to the driver). So basically the code now tells the game that a police car can have a driver, which is a police officer and a passenger next to the driver which also is a police officer. Even though the max amount of occupants is set to 3, which I set in bold up above, the code doesn't allow the cop car to spawn with more then 2 occupants.


The Bug (3)

Basically this bug is the same as above, but then for notoriety level 3 when STAG is active.

So same problem, same solution.

Bugged code:
Code:
    <Table>
        <Name>stag</Name>
        <level_info>
            <level_info>
                <level>3</level>
                <min_spawn_time>20</min_spawn_time>
                <max_spawn_time>25</max_spawn_time>
                <max_vehicle_occupants>3</max_vehicle_occupants>
                <max_vehicles>2</max_vehicles>
                <npc_cap>6</npc_cap>
                <specialist_cap>0</specialist_cap>
                <brute_cap>0</brute_cap>
                <veh_min_spawn_time>8</veh_min_spawn_time>
                <veh_max_spawn_time>15</veh_max_spawn_time>
                </level_info>
            </level_info>
        <spawn_flags>
            <Flag>Spawn on Land</Flag>
            <Flag>Active With Stag</Flag>
            </spawn_flags>
        <_Editor>
            <Category>Entries:STAG</Category>
            </_Editor>
        <group_info>
            <group_info>
                <level>3</level>
                <chance>0.7</chance>
                <tag_name>G_STAG_CopCar</tag_name>
                <vehicle_name>car_4dr_police02</vehicle_name>
                <variant_name>average</variant_name>
                </group_info>
            <group_info>
                <level>3</level>
                <chance>0.125</chance>
                <tag_name>G_STAG</tag_name>
                <vehicle_name>suv_4dr_02</vehicle_name>
                <variant_name>STAG</variant_name>
                </group_info>
            <group_info>
                <level>3</level>
                <chance>0.125</chance>
                <tag_name>G_STAG2</tag_name>
                <vehicle_name>suv_4dr_02</vehicle_name>
                <variant_name>STAG</variant_name>
                </group_info>
            <group_info>
                <level>3</level>
                <chance>0.05</chance>
                <tag_name>G_STAG_BikeCop</tag_name>
                <vehicle_name>bike_rocket02</vehicle_name>
                <variant_name>police</variant_name>
                </group_info>
            </group_info>
        <group_details>
            <group_details>
                <tag_name>G_STAG</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_stag_male_soldier2b</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_stag_fem_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_stag_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG2</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_stag_male_soldier2b</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG2</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_stag_male_soldier</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG2</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_stag_fem_soldier2b</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG_CopCar</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG_CopCar</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG_BikeCop</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop_motorcycle01_mw</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            </group_details>
        </Table>

So the file says that every vehicle with the tag G_STAG_CopCar can have a Driver which is a police officer and all the rest of the occupants are police officers as well, but there is no limit. Since when STAG is active, the STAG N-Forcers already show up at level 3 (just like SNG Bulldogs, the n-forcers have a driver, passenger and gunner) the amount of max occupants is set to 3.

The Fix

The fixed code (only bit with where the error was):
Code:
            <group_details>
                <tag_name>G_STAG_CopCar</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_STAG_CopCar</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>

I changed default to passenger 1, so now the cop car can only have a driver and passenger next to driver which are both cops.

The Bug (4)

This bug caused SWAT Lockdowns not to be able to spawn at notoriety level 3, like they were supposed to do.

The bugged code:

Code:
    <Table>
        <Name>police_riot</Name>
        <level_info>
            <level_info>
                <level>3</level>
                <min_spawn_time>40</min_spawn_time>
                <max_spawn_time>70</max_spawn_time>
                <veh_min_spawn_time>15</veh_min_spawn_time>
                <veh_max_spawn_time>30</veh_max_spawn_time>
                <max_vehicle_occupants>2</max_vehicle_occupants>
                <max_vehicles>1</max_vehicles>
                <npc_cap>2</npc_cap>
                <specialist_cap>0</specialist_cap>
                <brute_cap>0</brute_cap>
                </level_info>
            </level_info>
        <_Editor>
            <Category>Entries:Police/NG</Category>
            </_Editor>
        <spawn_flags>
            <Flag>Spawn on Land</Flag>
            <Flag>Force No Ram</Flag>
            </spawn_flags>
        <group_info>
[B]            <group_info>
                <level>3</level>
                <chance>.7</chance>
                <tag_name>G_CopUnmarked</tag_name>
                <vehicle_name>car_4dr_police02</vehicle_name>
                <variant_name>Ultimate</variant_name>
                </group_info>
            <group_info>
                <level>3</level>
                <chance>.3</chance>
                <tag_name>G_RiotCop</tag_name>
                <vehicle_name>van_2dr_riot02</vehicle_name>
                <variant_name>SWAT</variant_name>
                </group_info>[/B]
            </group_info>
        <group_details>
            <group_details>
                <tag_name>G_RiotCop</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop_swat_riot</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>True</outside_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                </group_details>
            <group_details>
                <tag_name>G_RiotCop</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                </group_details>
            <group_details>
                <tag_name>G_CopUnmarked</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_CopUnmarked</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            </group_details>
        </Table>

So, this is the code. The part put in bold proves that SWAT vans were supposed to show up. It says that there is 70% chance of a black cop car showing up and 30% chance of a SWAT Van showing up. But ingame, only black cop cars show up at level 3.

What causes this?
Simple, the upper part of the code adds a restriction, which makes the SWAT van impossible to spawn. This is the part I'm talking about:
Code:
                <max_vehicle_occupants>2</max_vehicle_occupants>
                <max_vehicles>1</max_vehicles>
                <npc_cap>2</npc_cap>
                <specialist_cap>0</specialist_cap>

Max_vehicles can be ignored, the porblem lays with the other three lines of code.
Basically from what I see, this part of the code is the same as for notoriety level 2, at which only black cop cars spawn with this part.
So the author simply copy and pasted that part, focused on the black cop cars and forgetting about the SWAT Van.

A SWAT van has: 1 driver (police officer) and 4 Riot Shield guys hanging on the back (2 at each sides). This creates a total of 5 occupants of which 4 fall under the category 'Specialist'

But the code says this:
Max_vehicle_occupants = 2. This means that vehicles at level 3 maximum can have 2 characters in it. The code also says: Specialist_cap = 0, which means that there can't be any specialists in the vehicles. This makes SWAT vans impossible to spawn.

The Fix

I just changed the values so they also make the SWAT Van spawnable. This is the updated code:
Code:
            <level_info>
                <level>3</level>
                <min_spawn_time>40</min_spawn_time>
                <max_spawn_time>70</max_spawn_time>
                <veh_min_spawn_time>15</veh_min_spawn_time>
                <veh_max_spawn_time>30</veh_max_spawn_time>
                <max_vehicle_occupants>6</max_vehicle_occupants>
                <max_vehicles>1</max_vehicles>
                <npc_cap>6</npc_cap>
                <specialist_cap>4</specialist_cap>
                <brute_cap>0</brute_cap>
                </level_info>

According to the code, there now can be max 6 npcs per vehicle of which 4 can be specialist.

Done! Tested this and now the SWAT lockdown does spawn as intended.

But: A new bug occurs: because of the new max vehicle occupants the black cop cars now has 4 cops in it because of this bit:

Code:
            <group_details>
                <tag_name>G_CopUnmarked</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_CopUnmarked</tag_name>
                <seat_name>Default</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>

The driver is a cop and all other passengers also are cops according to the code above.

Easy to fix, I just did this with the code:
Code:
            <group_details>
                <tag_name>G_CopUnmarked</tag_name>
                <seat_name>Driver</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>
            <group_details>
                <tag_name>G_CopUnmarked</tag_name>
                <seat_name>Passenger 1</seat_name>
                <npc_name>npc_cop</npc_name>
                <melee_brute_seat>False</melee_brute_seat>
                <weapons_brute_seat>False</weapons_brute_seat>
                <rollerbladers_seat>False</rollerbladers_seat>
                <outside_seat>False</outside_seat>
                </group_details>

Driver is a cop and the character in the passenger seat also is a cop. There can't be more then 2 characters in the black cop cars, so that fixes the final bug.


That was it! The bugs are fixed, in case you have read all this, you can download now ^^.

P.S.: There still is another bug left, which I didn't manage to fix yet. According to the files STAG Boats should appeaer when STAG is active but for some reason this bit of the code doesn't work. I will try to fix this as well.
 

Attachments

  • Notoriety Error Fix.rar
    7.8 KB · Views: 1,162
Last edited:
Very nice and informative write up. A couple things...
This seems right but after checking all roadblock variants in the roadblock_layouts.xtbl file I found this one:
police_lvl3_3lane.

FYI - There are no 3 lane roads in the game, so this roadblock layout will never spawn (and was not intended to be included at all in roadblock_layouts.xtbl in the final game).

It fixes some of the erros made by Volition when making the notoriety spawns for the game. After studying the files for a lot of time by now I found numerous bugs that could have been prevented, if the making of the notoriety wouldn't have been rushed through the way it has been.
I'm sure you did not intend it to be so, but comments like this can be seen as being somewhat hostile. First off, it dismisses the time/effort/stress that went into making this game in the first place (and I promise you there was more then you likely imagine). Second, it implies that you are an authority on a subject which you are not (what someone else intended). Yes, many of the issues you discovered are likely bugs, but there may also be a reason it is that way, that you are not aware of. Just be mindful that we all worked very hard to try and make the best game possible.

Yes, there are flaws. We will all be the first to admit that we made mistakes and that there are things we would like changed or improved. :p

+I'm pleased that you were able to make the notoriety system behave more how you would like/expect. That's the joy of modding. Keep it coming!
 
I'm sure you did not intend it to be so, but comments like this can be seen as be somewhat hostile. First off, it dismisses the time/effort/stress that went into making this game in the first place (and I promise you there was more then you likely imagine). Second, it implies that you are an authority on a subject which you are not (what someone else intended). Yes, many of the issues you discovered are likely bugs, but there may also be a reason it is that way, that you are not aware of. Just be mindful that we all worked very hard to try and make the best game possible.

Yes, there are flaws. We will all be the first to admit that we made mistakes and that there are things we would like changed or improved. :p

Matt, if you go back through the posts on our forum you will likely end up finding more negative comments like this towards Volition; some of them even from staff. Please try to understand that we have all been extremely frustrated over these past 4 years trying to mod these games and Volition's seeming apathy towards our efforts, which most definitely influenced modders' attitudes.

Now that we are moving forward with our combined efforts, we will no longer tolerate any negativity like this and will warn users and edit/delete posts that cross the line. I would consider this post a problem, and will ask yorpie to rewrite that part of the OP.

The point I'm trying to make is to please try and be a little understanding towards some of the posting history you might encounter, and also do not hesitate to let either myself or Minimaul know if you find anything along these lines. We would be glad to immediately take care of it.
 
The point I'm trying to make is to please try and be a little understanding towards some of the posting history you might encounter, and also do not hesitate to let either myself or Minimaul know if you find anything along these lines. We would be glad to immediately take care of it.
As a note, I didn't realize myself that this was an older thread, and was probably a deserved dig at the time. I can certainly understand past frustrations, and won't hold it against anyone. :p

All of us here have read anonymous online comments on random websites about our work which are 1000s of times more disrespectful and dismissive, so without speaking for everyone here I would like to think we have pretty thick skins for the most part. :)
 
I fixed..now SNG Bear will show up on level 5 (I added additional command line) You can download if you want SNG Bear at level 5.
 

Attachments

  • notoriety_spawn.xtbl
    197.2 KB · Views: 708
Back
Top